Avoid hardcoding year values #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david22swan
previously approved these changes
May 5, 2023
|
Looks like there are some Rubocop issues blocking the CI. If you could address those, @binford2k, this PR should be an easy review/merge. |
LukasAud
reviewed
Jun 28, 2023
LukasAud
reviewed
Jun 28, 2023
LukasAud
requested changes
Jun 28, 2023
Fixes puppetlabs#660 long term
Co-authored-by: SE-Stephen P Potter <56322084+spotter-puppet@users.noreply.github.com>
Co-authored-by: SE-Stephen P Potter <56322084+spotter-puppet@users.noreply.github.com>
Co-authored-by: Lukas Audzevicius <97180854+LukasAud@users.noreply.github.com>
jordanbreen28
force-pushed
the
fix_date_test
branch
from
eb1fda8
to
f6d6003
Compare
jordanbreen28
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #660 long term