(#236) agent_state_summary: Count nodes without report as unhealthy #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…nhealthy
It's possible that a Puppet Agent was stopped or disabled and all old
reports were garbage collected from PuppetDB. The node still exists in
PuppetDB, but when checking for a report the timestamp is null:
```
puppet query nodes[certname,report_timestamp]{}
```
```json
[
{
"certname": "pe.tim.local",
"report_timestamp": "2024-09-30T13:21:17.042Z"
},
{
"certname": "pe2.tim.local",
"report_timestamp": null
}
]
```
Previously we always assumed that `report_timestamp` has a valid
timestamp. With this patch we explicitly validate the timestamp and
count nodes withhout a timestamp as unhealthy.
Now with the fix:
```
puppet plan run pe_status_check::agent_state_summary --environment peadm log_healthy_nodes=true log_unhealthy_nodes=true
```
```json
{
"responsive": [
"pe.tim.local",
"pe2.tim.local"
],
"healthy_counter": 0,
"total_counter": 2,
"unhealthy_counter": 2,
"noop": [],
"unhealthy": [
"pe2.tim.local",
"pe.tim.local"
],
"healthy": [],
"changed": [
"pe.tim.local"
],
"no_report": [
"pe.tim.local"
],
"corrective_changes": [],
"used_cached_catalog": [
"pe2.tim.local"
],
"unresponsive": [],
"failed": []
}
```
taikaa
approved these changes
Oct 28, 2024
|
@bastelfreak apologies for the delay to review the PR. I tested the PR and no longer get the error. Thanks for adding this |
|
@MartyEwings hello are these failed tests alright to merge this PR? Thank you! |
|
Because nobody is reviewing this I raised support ticket #01302632. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that a Puppet Agent was stopped or disabled and all old reports were garbage collected from PuppetDB. The node still exists in PuppetDB, but when checking for a report the timestamp is null:
[ { "certname": "pe.tim.local", "report_timestamp": "2024-09-30T13:21:17.042Z" }, { "certname": "pe2.tim.local", "report_timestamp": null } ]Previously we always assumed that
report_timestamphas a valid timestamp. With this patch we explicitly validate the timestamp and count nodes withhout a timestamp as unhealthy.Now with the fix:
{ "responsive": [ "pe.tim.local", "pe2.tim.local" ], "healthy_counter": 0, "total_counter": 2, "unhealthy_counter": 2, "noop": [], "unhealthy": [ "pe2.tim.local", "pe.tim.local" ], "healthy": [], "changed": [ "pe.tim.local" ], "no_report": [ "pe.tim.local" ], "corrective_changes": [], "used_cached_catalog": [ "pe2.tim.local" ], "unresponsive": [], "failed": [] }Please check off the steps below as you complete each step
(SUP-XXXX) Add Super Duper State CheckReady for Reviewif there is one