Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-4870) Exclude comidi-route-metrics from Console collection #200

Merged

Conversation

Sharpie
Copy link
Member

@Sharpie Sharpie commented Apr 23, 2024

This commit updates the default configuration for Console metrics
collection to exclude the comidi-route-metrics dataset.
The console uses heavily parameterized API paths which can result
in this dataset containing several megabytes of information, most
of which is noise. This can consume several hundreds of megabytes
or gigabytes of storage for a day's worth of metrics and can lead
to disk space exhaustion if cleanup is not active.

If needed, this data can be recovered by analyzing the Console
access logs.

@Sharpie Sharpie requested a review from a team as a code owner April 23, 2024 22:42
Some commentary is also added that explains why various
`puppetserver` metrics are excluded.
This commit updates the default configuration for Console metrics
collection to exclude the `comidi-route-metrics` dataset.
The console uses heavily parameterized API paths which can result
in this dataset containing several megabytes of information, most
of which is noise. This can consume several hundreds of megabytes
or gigabytes of storage for a day's worth of metrics and can lead
to disk space exhaustion if cleanup is not active.

If needed, this data can be recovered by analyzing the Console
access logs.
@Sharpie Sharpie force-pushed the SUP-4870-exclude-console-comidi-route-metrics branch from 88c640e to 502b305 Compare April 23, 2024 22:54
Copy link
Contributor

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, and dropped the filesize on my box to about 10% of the original size 👍

@m0dular m0dular merged commit dae2f72 into puppetlabs:main Apr 24, 2024
31 checks passed
@Sharpie Sharpie deleted the SUP-4870-exclude-console-comidi-route-metrics branch April 30, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants