(maint) Add flexibility to logged? to not only match a single line
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileynewton
changed the title
logged? to not only match a single line
rileynewton
force-pushed
the
apply-logged-change-to-3.x
branch
4 times, most recently
from
29ef728 to
1a1b690
Compare
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 4.0.1 | |||
There was a problem hiding this comment.
Whoops corrected, applied an old stash at first and forgot to change it second time through
rileynewton
force-pushed
the
apply-logged-change-to-3.x
branch
from
1a1b690 to
60aedaa
Compare
|
Ignoring clj-kondo errors for this backport as tests pass, this will be the last need to use 3.x |
jonathannewman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for 3.x for use with 2021.7.x
logged?previously had an undocumented restriction that it would only return true if a single line matched (more than one would return false). This adds the flexibility to remove this restriction, as some log lines may legitimately be repeated.