Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add logic to handle roleChange event in stream #1080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented Feb 1, 2024

  • In the DataModifier class, there are several missing closing braces for the methods mapToJoinGroupEvent, mapToLeaveGroupEvent, mapToRequestEvent, mapToRemoveEvent, and mapToRoleChangeEvent. Please add closing braces for these methods.

  • In the mapToLeaveGroupEvent method, there is no implementation. Please add the necessary code for this method.

  • In the mapToRequestEvent method, there is a misplaced closing brace. Move the closing brace before the if condition, after the line eventData.raw = { verificationProof: data.verificationProof };.

  • In the mapToRemoveEvent method, there is no implementation. Please add the necessary code for this method.

  • In the buildChatGroupEventMetaAndRaw method, there is a missing closing brace for the raw variable declaration. Please add a closing brace after the line const raw: GroupEventRawData = { verificationProof: incomingData.verificationProof };.

  • In the buildChatGroupEventMetaAndRaw method, there is an unreachable return statement after the line return { meta };. Please remove this return statement as it is not necessary.

  • In the mapToGroupEvent method, there is a missing closing brace after the line chatId: incomingData.chatId,. Please add a closing brace for this object initialization.

  • In the pushStreamTypes.ts file, there is a missing closing brace for the SPAM enum value in the NotificationEventType enum. Please add a closing brace after the line 'notification.spam',.

  • In the pushStreamTypes.ts file, there is a missing closing brace for the RETRY_APPROVE enum value in the VideoEventType enum. Please add a closing brace after the line 'video.retry.approve'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants