New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added instanceids for push user and stream #1224

Merged

mohammeds1992 merged 1 commit into alpha from 1223-return-id-for-push-api-and-stream-init

Apr 12, 2024

Collaborator

mohammeds1992 commented Apr 12, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

My code follows the code style of this project.
My change requires changes to the documentation.
I have updated the documentation accordingly.
This PR does not contain plagiarized content.
The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers


          fix: added instanceids for push user and stream

16e65fb

mohammeds1992 requested a review from Aman035

April 12, 2024 10:56

github-actions bot commented Apr 12, 2024

In PushAPI.ts:

There is a missing comma after this.cache initialization.
There is a missing comma after this.pgpPublicKey.
There is a missing comma after this.profile.

In PushStream.ts:

There is a missing closing brace } at the end of if (!listen || listen.length === 0) {.

All looks good.

Aman035 approved these changes

View reviewed changes

mohammeds1992 merged commit 34263c9 into alpha

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet