Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linea Support #1228

Merged
merged 4 commits into from
May 30, 2024
Merged

Add Linea Support #1228

merged 4 commits into from
May 30, 2024

Conversation

pratham-bhatnagar
Copy link
Contributor

Fixes #1227

Copy link

There are a few issues and improvements needed in the code provided:

  1. In the Connect.tsx component:

    • The ConnectWrapper component is missing a closing curly brace }.
    • The Connect styled component is missing a closing backtick character for the background property.
    • The Disconnect styled component is missing a closing backtick character.
  2. In the helpers.ts file:

    • The AddressValidatorsType interface is missing a closing curly brace and semi-colon after the interface key.
    • The validateCAIP function is missing closing curly braces for the if statements inside it.
    • The validateCAIP function is missing the closing curly brace for the eip155 property in the AddressValidators.
    • The getFallbackETHCAIPAddress function is missing closing curly braces at the end.
    • The isValidETHAddress function is missing a closing curly brace.
  3. In the config.ts file:

    • The CHAIN_ID constant is missing a closing curly brace at the end.
    • The ALIAS_CHAIN_ID constant is missing an equal sign in its declaration.
    • There are missing closing curly braces for the objects in the VIEM_CORE_CONFIG constant.
    • There are missing commas at the end of the lines where objects are defined in the VIEM_CORE_CONFIG constant.
    • The ETH_CHAIN_ID constant should be defined as an object instead of an array.
    • The TOKEN constant is missing a closing curly brace.
    • The TOKEN_VIEM_NETWORK_MAP object is missing a closing curly brace.
    • The MIN_TOKEN_BALANCE constant is missing a closing curly brace.
    • The ABIS constant is missing a closing curly brace.
    • The VIEM_CONFIG constant is missing a closing curly brace.
    • The ALPHA_FEATURE_CONFIG constant is missing a closing curly brace.

After addressing these issues and fixing the syntax errors, the code will be in better shape.

@akp111 akp111 changed the base branch from alpha to main May 22, 2024 13:56
Copy link

There are a few mistakes and improvements that can be made in the code:

  1. In Connect.tsx:

    • Inside the ConnectWrapper, the margin style property should have a unit specified (e.g., margin: 20px).
    • In the network styled-component, the closing curly brace in & .network { is missing.
    • In the Connect styled-component, the closing curly brace is missing after the background property.
    • In the Disconnect styled-component, the closing curly brace is missing after the background property.
  2. In helpers.ts:

    • The isValidETHAddress function is missing a closing curly brace.
    • The validateCAIP function should have closing curly braces after the conditions.
    • In the AddressValidators object, the eip155 function is missing a closing curly brace.
    • The comment in the validateCAIP function should be properly closed with */.
    • In the ETH_CHAIN_ID object, the definition is incorrect, should use = instead of :.
  3. In config.ts:

    • The BLOCKCHAIN_NETWORK object is missing a closing curly brace after its definition.
    • The ETH_CHAIN_ID object should define the chain ids for different environments correctly, similar to ALIAS_CHAIN_ID.

After fixing these issues, the code should be checked again for any additional improvements.

@akp111 akp111 merged commit d51dda2 into main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

👾 [Other] - Add Support for Linea
3 participants