Search issue

[mishramonalisha76]

Fixes Issue

Changes proposed

• fixed search address issue in ChatPreviewList for dev and staging

Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• My change requires changes to the documentation.
• I have updated the documentation accordingly.
• This PR does not contain plagiarized content.
• The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

[rohitmalhotra1420]

@mishramonalisha76 let me know about this one when the merge conflicts are resolved.

Also add a video explaining the changes done in the PR.

[github-actions]

File: packages/uiweb/src/lib/components/chat/ChatPreviewList/ChatPreviewList.tsx

1. There is a typo in searchParamter, it should be searchParameter.
2. There is a missing closing brace } after the if (!error) block.
3. The console.debug(error); line is missing a closing parentheses ).

if (formattedChatId.includes('.')) {
  const address = await getAddress(formattedChatId, user ? user.env : CONSTANTS.ENV.PROD);
  if (address) formattedChatId = pCAIP10ToWallet(address);
  else {
    error = {
      code: ChatPreviewListErrorCodes.CHAT_PREVIEW_LIST_INVALID_SEARCH_ERROR,
      message: 'Invalid search',
    };
  }
}
if (pCAIP10ToWallet(formattedChatId) === pCAIP10ToWallet(user?.account || '')) {
  error = {
    code: ChatPreviewListErrorCodes.CHAT_PREVIEW_LIST_INVALID_SEARCH_ERROR,
    message: 'Invalid search',
  };
}
console.debug(error); // Add closing parentheses ')' here

// Add missing closing brace '}' here

//fetch latest chat
const latestMessage = await fetchLatestMessage({
  chatId: formattedChatId,
}); // Add closing parentheses ')' here

File: packages/uiweb/src/lib/helpers/chat/search.ts

1. There is a missing closing parentheses } in the getNewChatUser function.
2. There is a missing closing brace } in the getNewChatUser function after the return chatProfile;.
3. There is a missing closing brace } in the getAddress function after the return null;.

export const getNewChatUser = async ({
  searchText,
  fetchChatProfile,
  env,
  user,
}: getNewChatUserParamType): Promise<IUser | undefined> => {
  let chatProfile: IUser | undefined;
  let address: string | null = null;
  address = await getAddress(searchText, env);
  if (address) {
    chatProfile = await fetchChatProfile({ profileId: address, env, user });
    if (!chatProfile) chatProfile = displayDefaultUser({ caip10: walletToPCAIP10(address) });
    return chatProfile;
  } // Add missing closing brace '}'
}; // Add missing closing parentheses '}'

export const getAddress = async (searchText: string, env: Env) => {
  const udResolver = getUdResolver(env);
  const provider = new ethers.providers.InfuraProvider(CoreContractChainId[env], InfuraAPIKey);
  if (searchText.includes('.')) {
    try {
      if (!udResolver) throw new Error('No udResolver available for the network');
      address = await udResolver?.owner(searchText);
    } catch (err) {
      try {
        address = await provider.resolveName(searchText);
      } catch (err) {
        console.debug(err);
      }
      console.debug(err);
    }
    return address || null;
  } else if (await ethers.utils.isAddress(pCAIP10ToWallet(searchText))) {
    return searchText;
  } else {
    return null;
  } // Add missing closing brace '}'
}; // Add missing closing brace '}'

All looks good.

[github-actions]

In ChatPreviewSearchList.tsx:

1. The prop name "searchParamter" should be "searchParameter" for consistency.

In ChatUITest.tsx:

1. Missing closing tags for the Link elements. Add after each nested Link element.
2. Closing tag for the NavMenu styled component is missing. Add before the closing tag.

In app.tsx:

1. The import statement for ChatPreviewSearchListTest at the bottom is duplicated.
2. Incorrect path values in the Routes components. Each Route should have a correct path value attribute enclosed in {}.
3. Missing closing tag for the StyledApp styled component. Add before the export statement.

In ChatPreviewList.tsx:

1. Perhaps there are more relevant code that should be reviewed, else everything looks okay.

In ChatViewList.tsx:

1. The file is empty. Make sure the code implementation is added.

In ChatDataProvider.tsx:

1. "pushUser" should be defined in useState as null instead of undefined, for consistency.
2. There is a typo in the method name "readmode()", it should be "readMode()".
3. The comment "// traceStackCalls();" seems to be a commented out piece of code, consider removing it for clarity.

All looks good.

[mishramonalisha76]

@mishramonalisha76 let me know about this one when the merge conflicts are resolved.

Also add a video explaining the changes done in the PR.

The issue was in staging / dev it was giving error for search because unstoppable domains resolution was throwing error for polygon amoy as polygon amoy is not supported by unstoppable domains . In this pr i have handled the errors thrown by unstoppable domains for polygon amoy.

https://drive.google.com/file/d/1hLI55wEDqNA7QdJzIIf_moCk78naOSWE/view?usp=sharing
I have added a video explaining the working @rohitmalhotra1420

[rohitmalhotra1420]

@mishramonalisha76 added a couple of comments. Nothing major.

Also it's a screenshot instead of a video on the PR :)

[rohitmalhotra1420]

General Question?:

What's 1,5,137, 80002?

For now is it possible to have string values instead of these?

If no can we atleast store them into const which will help us giving them proper names and reuse across files.

[mishramonalisha76]

keeping it numbers because ud doesnot have follow the constants defined, these are specifically used for ud not reused anywhere @rohitmalhotra1420

[mishramonalisha76]

Everywhere else in the sdk we use a constant for determining chain-id but for ud its kind of an exception, as it doesnot support the test l1 and l1 chains

[rohitmalhotra1420]

What do you think about using these like:

const NUM1 = 1; // or const UD1 = 1 and similar approach for all others.

[rohitmalhotra1420]

@mishramonalisha76 and this one as well

[github-actions]

In ChatPreviewSearchList.tsx:

1. Typo: Conatiner should be Container.
2. Incorrect style declaration: The background, border, and height properties in styled-component Container should be declared without quotes.

In ChatUITest.tsx:

1. Missing closing tag for each Link element.

In App.tsx:

1. Typo: path should be wrapped in Route component.
2. Missing Routes component opening and closing tags.
3. Incorrect placement of Route components.

In ChatPreviewList.tsx:

1. Typo: Missing closing curly brace for if condition before console.debug(error);.

In ChatDataProvider.tsx:

1. Typo: readmode() should be readmode().
2. Typo: traceStackCalls() and resetStates() functions are commented out but their comments are not closed.

All looks good.

[github-actions]

In ChatPreviewSearchList.tsx:

1. Typo in the component name Conatiner, should be corrected to Container.
2. In the styled component Container, the CSS properties should not be enclosed in quotes. Replace background: '#ffeded' with background: #ffeded, border: '1px solid rgb(226,8,128)' with border: 1px solid rgb(226,8,128), and height: '28.5vh' with height: 28.5vh.

In ChatUITest.tsx:

1. There are missing closing tags for some of the <Link> elements. Each <Link> element should have a corresponding closing </Link> tag.
2. The nav-button class is referenced in the JSX, but the class definition is not provided in the styled component.

In App.tsx:

1. Incorrect import path for ChatPreviewSearchListTest component. It should be imported from '../../ChatUITest/ChatPreviewSearchListTest' instead of './ChatUITest/ChatPreviewSearchList'.

In ChatPreviewList.tsx:

1. Syntax error in the conditional statement. The if condition is duplicated. Remove the duplicate condition.
2. The console.debug statement is missing a closing brace }.

In ChatDataProvider.tsx:

1. The initialize function is missing a closing brace } before the comment // traceStackCalls();.

All other files appear to be free of mistakes.

Therefore, the corrections in the specified files are as follows:

ChatPreviewSearchList.tsx:

const Container = styled.div`
  background: #ffeded;
  border: 1px solid rgb(226,8,128);
  height: 28.5vh;
`;

ChatUITest.tsx:

<Link to="/ChatViewBubble" className="nav-button">
  CHAT BUBBLE
</Link>

App.tsx:

import ChatPreviewSearchListTest from '../../ChatUITest/ChatPreviewSearchListTest';

ChatPreviewList.tsx:

if (pCAIP10ToWallet(formattedChatId) === pCAIP10ToWallet(user?.account || '')) {
  error = {
    code: ChatPreviewListErrorCodes.CHAT_PREVIEW_LIST_INVALID_SEARCH_ERROR,
    message: 'Invalid search',
  };
}
console.debug(error);

ChatDataProvider.tsx:

if (!user?.readmode()) {
  await initStream(user);
}
// traceStackCalls();
resetStates();
setPushUser(user);

All looks good.

[corlard3y]

LGTM - functionality works fine

[GeekyKartikey]

Done, Looks good to me