Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed issue with pcaip and no caip in optin and optout #1273

Merged
merged 1 commit into from
May 15, 2024

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented May 10, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@akp111 akp111 linked an issue May 10, 2024 that may be closed by this pull request
@akp111 akp111 requested a review from Aman035 May 10, 2024 14:41
Copy link

  • In the list method of the Notification class, there is a missing closing brace } after the const promises block, which is causing a syntax error.
  • The list method should handle the error case when options parameter is not provided to set a default value for options as an empty object {}.
  • In the list method, there is a missing closing brace } after the return feedRes statement, causing syntax error.
  • A try...catch block is missing the closing brace } in the list method.
  • There are multiple typos in comments: 'notifcaiton' should be 'notification'.
  • In the subscriptions method of the Notification class, the error handling is incorrect. The throw new Error statement should be placed before the return statement.
  • In the subscribe method of the Notification class, the closing brace } is missing after the onError property in the PUSH_CHANNEL.subscribeV2 method call.
  • In the unsubscribe method of the Notification class, the closing brace } is missing after the PUSH_CHANNEL.unsubscribeV2 method call.
  • In the tests file, expect(res.message) should be expect(res).to.have.property('message').
  • In the tests file, there are issues with indentation in some test cases.
  • In the tests file, there are missing closing parentheses ) for some function calls.

After corrections:

All looks good.

@akp111 akp111 self-assigned this May 10, 2024
@akp111 akp111 merged commit 8fa224a into main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Support fo pcaip and nocaip for optin optout
2 participants