Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyber connect integration #1281

Merged
merged 2 commits into from
May 15, 2024
Merged

Cyber connect integration #1281

merged 2 commits into from
May 15, 2024

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented May 15, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@akp111 akp111 requested a review from mohammeds1992 May 15, 2024 07:52
Copy link

In the file packages/examples/sdk-frontend-react/src/app/components/Connect.tsx:

  1. There is a typo in the variable name 'NwMappingType', it should be 'NetMappingType'.
  2. In the 'ConnectWrapper' styled component, the 'margin' property should have units specified (e.g. margin: 20px;).
  3. In the 'ConnectWrapper' styled component, the closing curly brace for the '.network' selector is missing.
  4. In the 'StyledButton' component, the 'cursor' property is missing a semicolon at the end.
  5. The 'Connect' and 'Disconnect' styled components are missing closing backticks for the template literal.
  6. In the 'Disconnect' styled component, the 'background' property should have RGB values in the format 'rgb(226, 8, 128);'.

Overall, the code needs some minor corrections related to naming conventions, CSS syntax, and missing characters in styled components.

In the file packages/examples/sdk-frontend-react/src/app/helpers.ts:

  1. There is a missing closing curly brace for the 'AddressValidatorsType' interface.
  2. The comment in the 'eip155' validator function is not closed properly with a '*/'.
  3. There is a missing closing curly brace for the 'AddressValidators' object.
  4. The 'validateCAIP' function is missing a closing brace for the conditional block.
  5. The 'validateCAIP' function should handle the case when 'validatorFn' is undefined.
  6. In the 'getFallbackETHCAIPAddress' function, the comment should be improved for clarity.

In the file packages/restapi/src/lib/config.ts:

  1. There is a missing closing curly brace for the 'BLOCKCHAIN_NETWORK' object.
  2. The 'ALIAS_CHAIN_ID' constant declaration is missing a type definition.
  3. In the 'ALIAS_CHAIN_ID' object, the 'OPTIMISM' section is missing a closing brace.
  4. The 'POLYGONZKEVM' key in the 'ALIAS_CHAIN_ID' object should have a closing brace.
  5. The 'BERACHAIN' and 'CYBERCONNECT' sections in the 'ALIAS_CHAIN_ID' object are missing closing braces.
  6. The 'ETH_CHAIN_ID' object is missing the 'DEV' key.
  7. The 'CHAIN_ID' object is missing a closing curly brace.
  8. The 'CHAINS_NAME' object is missing a closing curly brace.
  9. There are multiple 'NETWORK' properties in the 'CONFIG' object that should be resolved.
  10. The 'TOKEN' object is missing closing braces for several ENV values.
  11. The 'API_BASE_URL' object is missing a closing curly brace.

Overall, there are several syntax errors, missing braces, and incomplete definitions in the code that need to be corrected.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 5bfb810 into main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants