-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUG] - <Skeleton loading in dark mode appears like light mode in chat> #1313
Conversation
File: packages/uiweb/src/lib/components/chat/ChatPreview/ChatPreview.tsx
All looks good. File: packages/uiweb/src/lib/components/chat/ChatViewList/ChatViewList.tsx
All looks good. File: packages/uiweb/src/lib/components/chat/ChatViewList/MessageEncryption.tsx
All looks good. File: packages/uiweb/src/lib/components/chat/reusables/ProfileContainer.tsx
All looks good. File: packages/uiweb/src/lib/components/chat/theme/index.ts No content provided for review. File: packages/uiweb/src/lib/components/reusables/sharedStyling.tsx No content provided for review. |
…keleton dark mode fix #1308
In the file
In the file
In the file
In the file
For the file Please address the above issues, and if there are no further mistakes in the provided files, please write 'All looks good.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In ChatPreview.tsx:
In MessageEncryption.tsx:
In ProfileContainer.tsx:
Overall, some minor syntax and formatting issues need to be addressed. Here are the corrections made: // Inside the ternary operator in Message component
<CiImageOn />
File
(FaFile />) // Inside the NO_ENCRYPTED_GROUP object
NO_ENCRYPTED_GROUP: {
text: `Messages in this group are not encrypted`,
}, // Inside the remaining objects in MessageEncryption.tsx
PREVIEW: {
IconComponent: (
<PublicChatIcon
size={15}
color={theme?.iconColor?.subtleColor}
/>
),
text: `Chat in preview mode. Only public groups messages are visible`,
},
LOADING: {
IconComponent: null,
text: `Please wait while Push Chat loads the status of this chat...`,
}, // Inside the second Section component in ProfileContainer.tsx
<Div
ref={blockieContainerRef}
width={customStyle?.imgHeight ?? '48px'}
></Div>
</Section> // Inside the Tooltip and RecipientSpan components in ProfileContainer.tsx
<Tooltip content={copyText}>
<Section
justifyContent="flex-start"
gap="5px"
cursor="pointer"
minHeight="22px"
minWidth="140px"
onMouseEnter={() => {
const text = member.chatId === member.recipient ? 'Copy Chat ID' : 'Copy Wallet';
setCopyText(text);
}}
onMouseLeave={() => setCopyText('')}
onClick={() => {
copyToClipboard(pCAIP10ToWallet(member?.recipient || ''));
setCopyText('Copied');
}}
animation={theme.skeletonBG}
className={loading ? 'skeleton' : ''}
>
<RecipientSpan
fontSize={member?.name || member?.web3Name ? '14px' : customStyle?.fontSize ?? '18px'}
fontWeight={member?.name || member?.web3Name ? '500' : customStyle?.fontWeight ?? '400'}
color={
member?.name || member?.web3Name
? theme.textColor?.modalSubHeadingText
: customStyle?.textColor ?? theme.textColor?.modalSubHeadingText
}
position="relative"
whiteSpace="nowrap"
cursor="pointer"
textAlign="left"
>
{member?.name && member?.web3Name
? `${member?.web3Name} | ${member.abbrRecipient}`
: member.abbrRecipient}
</RecipientSpan>
{copy && copyText && (
<Div cursor="pointer">
<CopyIcon
size={16}
color={theme?.iconColor?.primaryColor}
/>
</Div>
)}
</Section>
</Tooltip> All looks good. |
In ChatPreview.tsx:
In ChatViewList.tsx:
Please correct these issues in the respective files. |
In ChatPreview.tsx:
In ChatViewList.tsx:
Other files are not analyzed as per the task. Please review these points and make necessary corrections. |
fix #1308
Skeleton loading in dark mode appears like light mode in chat
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers