Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Release Version 1.3.6 #1318

Merged
merged 9 commits into from
May 24, 2024
Merged

Main Release Version 1.3.6 #1318

merged 9 commits into from
May 24, 2024

Conversation

rohitmalhotra1420
Copy link
Collaborator

Fixes Issue

Closes: #1283, #1271

Changes proposed

  • Added support for chat reactions.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

HarshRajat and others added 9 commits May 15, 2024 20:50
added relative imports for better management
…eb-chat

Fixed ChatUI Components responsiveness
* fix: fixed lint issues

* fix: added test for chat preview search list

* fix: fixed review comment

* Update ChatPreviewSearchList.tsx
* fix: fixed support chat init issue

* fix: fixed lint errors
* Fixed responsiveness in mobile for UIWeb:Chat

* fixes text alignment on frames preview link to come on right

* scroll bar fixes

* fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group

* removed unnecessary console.debug

* removed unnecessary console.debug

* Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble

* Resolved comments
@rohitmalhotra1420 rohitmalhotra1420 merged commit cad48bc into main May 24, 2024
1 check passed
Copy link

In index.js:

  1. Typo: 'generateRandomWordsWithTimestamp' function is defined but never used.
  2. Typo: There is a missing closing bracket '}' after the 'reference' value in the 'userAlice.chat.send' function.
  3. Commented out code should be removed from the file for better readability.

In ChatSupportTest.tsx:

  1. Typo: 'greetingMsg' prop typo, should be 'greetingMessage'.
  2. Commented out code should be removed for better readability.
  3. Typos: 'bgColorPrimary', 'bgColorSecondary', 'moduleColor' should be camelCase.

In ChatPreview.tsx:

  1. Syntax error: Unneeded text lines after the selected prop.

In ChatPreviewSearchList.tsx:

  1. Typo: Container is misspelled as Conatiner.
  2. Styling: Background and border values should be inside a styled component.
  3. Typo: SearchParameter should be camelCase.

In ChatUITest.tsx:

  1. Structure: Missing closing tags in the Links section.
  2. Invalid markup: Link components should be wrapped in a Fragment <> or a div.
  3. Invalid markup: NavMenu styled component is defined within the function component.

In ChatViewComponent.tsx:

  1. Typo: ChatViewComponentCard styled component is defined but unused.

In ChatViewListTest.tsx:

  1. Missing import: MODAL_POSITION_TYPE and MODAL_POSITION_TYPE are not imported.
  2. Syntax error: No closing tag for the Link component 'CHAT VIEW'.

In ChatPreviewList.tsx, ChatProfile.tsx, ChatViewComponent.tsx, ChatViewBubble.tsx:

  1. The files seem to be empty and should be checked for content.

Overall, there are various typos, syntax errors, and unnecessary code/markup present in the files. Please make the necessary corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Fix Support chat
4 participants