Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - <Skeleton loading in dark mode appears like light mode in chat> #1324

Merged
merged 1 commit into from
May 29, 2024

Conversation

corlard3y
Copy link
Collaborator

#1308

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In ChatPreview.tsx:

  1. There is a missing opening tag for <Section> before className={options.readmode ? 'skeleton' : ''}.
  2. There is a missing opening tag for <Section> before <FaFile /> File.
  3. The return statement is missing a closing parenthesis after <CiImageOn />.

In ChatViewList.tsx:

  1. There is a missing closing brace } after the return statement inside the second useEffect block.
  2. There is a missing opening brace { before the if statement if (Object.keys(participantRemoveStream || {}).length > 0 && participantRemoveStream.constructor === Object).
  3. Inside the transformSteamMessage function, the closing brace } is misplaced, it should close after the final return statement.

In MessageEncryption.tsx:

  1. There are missing closing braces } for the objects NO_ENCRYPTED_GROUP, PREVIEW, and LOADING.

In ProfileContainer.tsx:

  1. There is a missing closing angle bracket > for the opening <Section> tag before flexDirection="column".
  2. There is a misplaced closing brace } before the className={loading ? 'skeleton' : ''} inside the Tooltip component.
  3. The closing parenthesis is missing after setCopyText('Copied') inside the onClick event in the Section component.
  4. There is a missing closing brace } after the <RecipientSpan> component declaration.

Please make the necessary corrections.

@corlard3y corlard3y requested review from rohitmalhotra1420 and mishramonalisha76 and removed request for rohitmalhotra1420 May 28, 2024 17:53
@rohitmalhotra1420 rohitmalhotra1420 added Quick PR A PR that can be approved before finishing a coffee DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. labels May 29, 2024
@corlard3y corlard3y removed the DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. label May 29, 2024
@corlard3y corlard3y merged commit 8512e41 into alpha May 29, 2024
1 check passed
@corlard3y corlard3y deleted the skeleton-loading-dark-mode branch May 29, 2024 13:51
@rohitmalhotra1420 rohitmalhotra1420 mentioned this pull request May 31, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants