fixes ui representation for domain resolution

[mishramonalisha76]

Fixes Issue

Closes #1327

Changes proposed

Fixed the domain representation by showing the domain directly when a domain is passed in props. This is implemented in ChatProfile , ChatPreviewSearchList and ChatPreview components

Check List (Check all the applicable boxes)

• My code follows the code style of this project.
• My change requires changes to the documentation.
• I have updated the documentation accordingly.
• This PR does not contain plagiarized content.
• The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

[github-actions]

In the file packages/uiweb/src/lib/components/chat/ChatPreviewSearchList/ChatPreviewSearchList.tsx:

1. Typo: searchParamter should be corrected to searchParameter.
2. Misplaced code snippet: The if condition else if (!options?.searchParamter) seems to be missing a preceding }. It should be placed before the catch block.
3. Minor typo: ChatProfileSearchListErrorCodes should be checked for consistency with other error code constants.

In the file packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx:

1. Typo: abbrRecipient should be corrected to abbreviatedRecipient.
2. Typo: getAbbreiatedRecipient should be corrected to getAbbreviatedRecipient.
3. chatId in the line profile.web3Name = chatId.includes('.') ? chatId : null seems to be missing declaration. It should be replaced with derivedChatId.
4. Misplaced code snippet: The setupWeb3Name(profile.recipient); and the following block of code seem to be misplaced inside the catch block and should probably be outside the try-catch block.
5. fetchProfileData seems to be a commented out useEffect that should be reviewed and potentially utilized.
6. Minor typo: asynchrounously should be corrected to asynchronously.
7. Inconsistent variable naming: profile.icon and profile.chatPic could be standardized for clarity and consistency.
8. Inconsistent error handling: There are mixed usages of console.error, console.warn, and throw new Error. It could be good to standardize on one approach.

In the packages/uiweb/src/lib/components/chat/helpers/helper.ts file: No content was provided.

Please make the necessary corrections and improvements mentioned above.

[abhishek-01k]

Functionality review done. Its working

[rohitmalhotra1420]

Let's put formattedChatId.includes('.') this in a utility function. Something like

const getChatId=(id:string)=> id.includes(".")? id : null

[mishramonalisha76]

okay

[mishramonalisha76]

@rohitmalhotra1420 added the change

[github-actions]

In the ChatPreviewSearchList.tsx file:

• There is a typo in the import statement for IChatPreviewSearchListProps. It is imported as IChatPreviewSearchPreviewProps.
• The loadMoreChats function is missing an opening curly brace { before the else if (!options?.searchParamter) { statement.
• The error variable is assigned values in the catch block, but it should be declared before the try block to avoid a scope issue.
• There is a typo in the loadMoreChats function where options?.searchParamter should be options?.searchParameter.
• There is a missing closing curly brace } at the end of the file.

In the ChatProfile.tsx file:

• There is a typo in the fetchProfileData function which is commented out. It should be fetchProfileInfo.
• There is a missing closing curly brace } at the end of the file.

In the helper.ts file:

• There is a missing closing curly brace } at the end of the transformStreamToIMessageIPFSWithCID function.
• The checkIfNewRequest function is missing a closing curly brace }.
• The transformStreamToIMessageIPFSWithCID function is missing a closing curly brace }.

Please correct the mentioned issues in the respective files.

[rohitmalhotra1420]

@mishramonalisha76 I meant using the function everywhere so we don't have to use .includes everywhere and keep this logic in a single function.

[mishramonalisha76]

understood

[mishramonalisha76]

@rohitmalhotra1420 this logic is only in two places , most of the places we have to check if chatID.includes('.') then it doesnot something or something else. Should we just make a function to check if a string includes another substring?

[github-actions]

In the first file (ChatPreviewList.tsx), there are several issues:

1. Typo in importing "IFeeds":
   Change: import { CONSTANTS, IFeeds, IUser } from '@pushprotocol/restapi';
   To: import { CONSTANTS, IFeed, IUser } from '@pushprotocol/restapi';

2. Typo in importing "ChatPreviewListErrorCodes":
   Change: import ChatPreviewListErrorCodes
   To: import { ChatPreviewListErrorCodes }

3. Typo in function name "transformChatItems" - it seems to be missing:
   Add: transformChatItems function import.

4. Missing curly braces in useEffect for chatRejectStream:
   Change:

   if (Object.keys(chatRejectStream || {}).length > 0 && chatRejectStream.constructor === Object) {
     removeChatItems([chatRejectStream.chatId]);
   }, [chatRejectStream]);

   To:

   if (Object.keys(chatRejectStream || {}).length > 0 && chatRejectStream.constructor === Object) {
     removeChatItems([chatRejectStream.chatId]);
   }
   }, [chatRejectStream]);

5. Typo in IChatPreviewList interface - Missing curly braces around the exported types section:
   Change:

   /**
    * Interfaces & Types
    ChatPreviewListErrorCodes,
    Group,
    IChatPreviewListError,
    IChatPreviewListProps,
    IChatPreviewPayload,
    */

   To:

   /**
    * Interfaces & Types
    {
      ChatPreviewListErrorCodes,
      Group,
      IChatPreviewListError,
      IChatPreviewListProps,
      IChatPreviewPayload,
    }
    */

6. A missing closing brace in the handleSearch function inside the try block.
   Add a closing brace } before the if (!error) statement.

After addressing these issues, the code seems to be correct.

All looks good.

[mishramonalisha76]

@rohitmalhotra1420 made the changes can you please check now if its alright?