Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added sendNotificationV3 #1343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Jun 6, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented Jun 6, 2024

In the helpers.ts file:

  1. There are several missing closing curly braces } after each spread operator of inputOptions?.payload properties. They need to be added.
  2. The default case inside the switch (senderType) statement is missing a closing curly brace }. It should be added.
  3. The switch (senderType) statement seems to be incomplete as it lacks the necessary cases for handling different senderType values. It needs to be revised to include all cases.
  4. The throw new Error('Invalid SenderType'); statement inside the case 1 of the switch (senderType) statement should be moved outside the switch block.
  5. The getVerificationProofV2 function is missing a closing curly brace } at the end.
  6. The getSource function seems incomplete as it lacks implementation details for handling different scenarios based on senderType and identityType.

In the other files, no issues were found.

Therefore, the corrections need to be made in the helpers.ts file, while the rest of the files seem to be fine.

All looks good.

@mohammeds1992 mohammeds1992 self-requested a review June 13, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants