Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat implementation #1349

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@mohammeds1992 mohammeds1992 linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link

In file packages/restapi/src/lib/pushapi/chat.ts:

  1. In the history method, there are missing closing brackets } after the if conditions for setting the reference variable.

  2. In the message method, there is a missing opening bracket { after the declaration of the reference variable.

  3. In the send method, there is a missing closing bracket } after the throw new Error statement.

  4. The listType variable used inside the history and message methods is not defined. It should be defined before being used.

  5. There is a missing return statement before return historyMessages.map((message: any) => ({ ...message, listType })); in the history method.

  6. In the decrypt method, the parameters for PUSH_CHAT.decryptConversation seems to be incomplete as it's missing some arguments.

Please address the issues mentioned above to ensure the code functions correctly.

Let me know if you need further clarification or assistance with fixing the identified issues.

@mohammeds1992 mohammeds1992 merged commit f5778ba into main Jun 12, 2024
1 check passed
@mohammeds1992 mohammeds1992 added this to the M1 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chat.Message Implementation
2 participants