Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search response #1398

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: search response #1398

merged 2 commits into from
Sep 26, 2024

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Sep 26, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

  1. In the SearchChannelOptionsType type definition, the limit property should be defined as an object with min and max keys instead of just a number:
limit?: {
   min: number;
   max: number;
};
  1. The getQueryParams function is likely missing in the current files. Make sure it is implemented in the ../helpers file.

  2. There is a redundant import for expect from 'chai' in the test files and it is not being used. You can remove this import to clean up the code.

  3. In the test file for PUSH_CHANNELS.search, there is an it.only statement being used which might unintentionally exclude other tests from running. It's recommended to use it instead of it.only for normal test execution.

Other than these points, the code logic and structure seem to be fine.

So, the final comment for the code would be:
"All looks good."

Copy link

All looks good.

@akp111 akp111 merged commit 5bef248 into main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants