Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A fresh start #62

Open
jonathanfine opened this issue Nov 2, 2014 · 1 comment
Open

A fresh start #62

jonathanfine opened this issue Nov 2, 2014 · 1 comment

Comments

@jonathanfine
Copy link
Contributor

I've decided that the best way to fix issues

is to make a fresh start.

I've done this at https://github.com/jonathanfine/py-mcpi

I believe that https://github.com/jonathanfine/py-mcpi/tree/add-python3 is fit for release, but I've not tested it. (This work is closely based on the early commits to this project, and particular thanks are due to @doismellburning and @ghickman , whose steps I have followed.)

It would be good to have some testing, and I'm working on that in https://github.com/jonathanfine/py-mcpi/tree/add-tests.

My way of working will be to add tests that pass on the original codebase, and then merge them into the add-python3 branch. This ensures that the tests are run on both the original and new code, resolving #61. I followed this path to discover the unicode-bytes-socket problem that @ghickman found before me.

The changes I'm making to the code are small, so this will help a great deal with #57.

@bennuttall
Copy link
Member

Hi all

Where are we up to with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants