-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyRiemann-qiskit v0.1.0 #189
Conversation
remove old pyton setup.py develop
necessary after all
update base image
use pip to install in develop mode
comment workaround
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok for me to release v0.1.0.
In the gallery, we could create a new item "Classification on other datasets", grouping the examples on Titanic dataset, multiclass EEG and dimension reduction. These three examples are neither ERP nor toy datasets classification examples.
@gcattan, keep the good practice of creating the branch in your personal fork, and not from the upstream repository.
(cherry picked from commit 97062de)
Yes, sorry about that, I will pay attention for the next PRs. |
add missing readme
I wanted to add that I am against these 0.X.X versioning in general. Why never using the first digit? |
@toncho11 I try to follow semantic versioning. In X.Y.Z, X is for major, Y for minor, and Z for patches. Yes, I plan to release on github and pypi, but I would like to merge #191 first. |
@sylvchev @qbarthelemy @toncho11
I think we have enough material to deliver v0.1.0. We made good progress with the quantum MDM, enabled multiclass classification, and included more examples.
We have a few ideas for v0.1.1 that we can discuss :
Let me know what you think.