-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with qiskit-symb #313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without any value judgement on the quality of the qiskit-symb
code, I am not in favor of adding a package with a single maintainer as a mandatory dependency.
Is it possible to modify the code to add qiskit-symb in pyRiemann-qiskit\doc\requirements.txt
but not in pyRiemann-qiskit\requirements.txt
?
Functions depending on qiskit-symb would only be called when building the doc.
Yes, you are right. I am putting qiskit-symb as an optional dependency. |
cb70764
to
44d875a
Compare
copy cached feature maps to examples at runtime
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
Co-authored-by: Quentin Barthélemy <q.barthelemy@gmail.com>
(features map not found)
Correct syntax of cp command
…job. Disabling multhithreading for one of the moabb example
Thanks for the review @qbarthelemy! Took a bit of work to correct the pipelines. |
Issue: #287
This PR aims to integrate pyRiemann-qiskit with qiskit-symb.
There is a performance benefit using qiskit-symb with a small number of qubits (see here)
In practice, in the light benchmark, we can divide the simulation time of QSVC by two using the default parameters.
The solution here was discussed with the library owner in this issue.
There are two elements of complexity in the current implementation:
numpy.einsum
:This PR workaround this by caching the computation (the feature map is always the same in general).
evaluate
method of the newSymbFidelityStatevectorKernel
.