Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy.NAN crash #1758

Closed
KiARC opened this issue Sep 10, 2024 · 2 comments
Closed

numpy.NAN crash #1758

KiARC opened this issue Sep 10, 2024 · 2 comments

Comments

@KiARC
Copy link

KiARC commented Sep 10, 2024

Tested versions

  • Reproducible in 3.3.1, current latest version

System information

Linux dev container, no GPU

Issue description

This issue has already been fixed in #1732, but after months that PR hasn't made it into a release. A patch really should be released, because as it stands the latest stable version of the library does not work when NumPy>=2 is present. These kinds of patches should be made available ASAP so that people can use the library. Could a 3.3.2 release be created in order to make the patch available?

Minimal reproduction example (MRE)

Colab unfortunately is not cooperating right now, but if pyannote is used in an environment with numpy>=2 it will crash. Again, this is a fixed issue, but the patch has not been released.

@hbredin
Copy link
Member

hbredin commented Sep 11, 2024

Just released 3.3.2 with latest fix.

@hbredin hbredin closed this as completed Sep 11, 2024
@KiARC
Copy link
Author

KiARC commented Sep 11, 2024

Thank you so much, I really appreciate the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants