Hi @TusharNaugain, your potential solution seems to be just a rephrase of the steps that have been outlined already. Could you please elaborate on how you plan to implement these changes? A proposal to fix this must be refined enough and filled with details that describe your approach to the codebase succinctly.

This might not be a "good first issue", since it assumes some knowledge of what is going on with the processing and solving of our models – please look for issues labelled as "easy" if you wish to contribute and are looking for where to start!

agree with @agriyakhetarpal that this is not a good first issue, you need to have a good knowledge of how pybamm represents and processes a model via discretisation.

I didn't implement the BaseModel.set_initial_conditions function, @valentinsulzer I think this was you, are you happy with my proposed solution?

I think adding the variables when discretizing is a good idea, not sure why we also need to disallow outputs with the same name as set_initial_conditions should just look for the variable with the right name and ignore any others

if there is already an output with the same name as the variable then the discretisation class won't be able to add the variable (its a dict mapping str to an expression as I recall)