-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated parameter file and example notebook for lithium plating on composite electrodes #4691
Open
mohammedasher
wants to merge
5
commits into
pybamm-team:develop
Choose a base branch
from
mohammedasher:composite_plating
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6bf64e0
Updated parameter file and example notebook for lithium plating on co…
mohammedasher b384318
style: pre-commit fixes
pre-commit-ci[bot] 2664799
Merge branch 'develop' into composite_plating
mohammedasher 0cba3d2
Remove 'lithium-plating - Copy.ipynb:Zone.Identifier' from pull request
mohammedasher 914e491
Merge branch 'composite_plating' of https://github.com/mohammedasher/…
mohammedasher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
392 changes: 392 additions & 0 deletions
392
docs/source/examples/notebooks/models/lithium-plating-composite.ipynb
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these parameters from the same paper as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These parameters are not from Chen2020. Currently, no definitive research papers are providing these parameters for composite electrodes. As a placeholder, we use parameters from OKane2022 assuming that the parameters for both phases are identical.
Please note that these values are provisional and should be updated as and when new research becomes available. While this is not ideal, these parameters are essential to enable simulation and further development of degradation mechanisms in composite electrodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to keep named parameter sets true to what is in the paper (I know this isn't true in all cases, but we should aim for this). It would be better to add the extra parameters directly in the example notebook rather than modify the Chen 2020 set.