Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make particle mechanics work with composite electrodes #4698

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

aabills
Copy link
Contributor

@aabills aabills commented Dec 19, 2024

Description

Makes particle mechanics work with composite electrodes

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python -m pytest (or $ nox -s tests)
  • The documentation builds: $ python -m pytest --doctest-plus src (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (a7253b8) to head (480e632).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4698   +/-   ##
========================================
  Coverage    99.22%   99.22%           
========================================
  Files          303      303           
  Lines        23070    23077    +7     
========================================
+ Hits         22891    22898    +7     
  Misses         179      179           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rtimms rtimms enabled auto-merge (squash) December 20, 2024 08:59
@rtimms rtimms merged commit f0f66da into pybamm-team:develop Dec 20, 2024
23 of 24 checks passed
SagarPal8894 added a commit to SagarPal8894/PyBaMM that referenced this pull request Dec 20, 2024
@SagarPal8894
Copy link

Hi @aabills and @rtimms, Apologies for the above reverting commit made mistakenly. It is completely unintentional and is not implying anything.
Thanks.

@aabills
Copy link
Contributor Author

aabills commented Dec 20, 2024

Hey @SagarPal8894, no worries, it looks like that is on your fork of pybamm, on which you are free to do whatever you please.

@SagarPal8894
Copy link

Hey @aabills and @rtimms , it would be great if you guys also look at the composite electrode porosity change compatibility with cracking particle mechanics also.
Thanks.
#4417 by @DrSOKane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants