Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary test dependencies on RSA-512 #11444

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Remove unnecessary test dependencies on RSA-512 #11444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45ed1b3
Remove unnecessary test dependencies on RSA-512
davidben Aug 17, 2024
bbdc241
Keep using RSA-512 for test_rsa_fips_small_key as a RHEL-8 accommodation
davidben Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions tests/hazmat/primitives/test_rsa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,8 +821,8 @@ def test_prehashed_digest_length(
),
skip_message="Does not support PSS.",
)
def test_unsupported_hash(self, rsa_key_512: rsa.RSAPrivateKey, backend):
private_key = rsa_key_512
def test_unsupported_hash(self, rsa_key_2048: rsa.RSAPrivateKey, backend):
private_key = rsa_key_2048
message = b"one little message"
pss = padding.PSS(mgf=padding.MGF1(hashes.SHA256()), salt_length=0)
with raises_unsupported_algorithm(_Reasons.UNSUPPORTED_HASH):
Expand Down Expand Up @@ -850,9 +850,9 @@ def test_unsupported_hash_pss_mgf1(self, rsa_key_2048: rsa.RSAPrivateKey):
skip_message="Does not support PSS.",
)
def test_prehashed_digest_mismatch(
self, rsa_key_512: rsa.RSAPrivateKey, backend
self, rsa_key_2048: rsa.RSAPrivateKey, backend
):
private_key = rsa_key_512
private_key = rsa_key_2048
message = b"one little message"
h = hashes.Hash(hashes.SHA512(), backend)
h.update(message)
Expand Down Expand Up @@ -2137,6 +2137,8 @@ def test_rsa_encrypt_key_too_small(self, key_data, pad, backend):
skip_message="Requires FIPS",
)
def test_rsa_fips_small_key(self, rsa_key_512: rsa.RSAPrivateKey, backend):
# Ideally this would use a larger disallowed key like RSA-1024, but
# RHEL-8 thinks that RSA-1024 is allowed by FIPS.
with pytest.raises(ValueError):
rsa_key_512.sign(b"somedata", padding.PKCS1v15(), hashes.SHA512())

Expand Down