Silencing mmap mypy warning on windows #11570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
even though the lib doesn't exist on this platform
alex
reviewed
Sep 9, 2024
| large_data = mmap.mmap(-1, 2**29 + 2**20, prot=mmap.PROT_READ) | ||
| # Silencing mypy warning on Windows, even though mmap doesn't exist. See: | ||
| # https://mypy.readthedocs.io/en/stable/common_issues.html#version-and-platform-checks | ||
| if sys.platform == "win32": |
There was a problem hiding this comment.
Unfortunately this will produce coverage issues, since it's never reached.
I wonder if an assert sys.platform in {"linux", "darwin"} would work?
There was a problem hiding this comment.
I've seen it in the documentation, and tried it, as well as assert sys.platform != "win32", without any success. it seems it only works to silence the whole file 😞
|
Pushed new version, probably the dirtiest we can do without going for |
alex
reviewed
Sep 9, 2024
| @@ -255,7 +255,7 @@ def test_update_into_buffer_too_small_gcm(self, backend): | |||
| sys.platform not in {"linux", "darwin"}, reason="mmap required" | |||
| ) | |||
| def test_update_auto_chunking(): | |||
| large_data = mmap.mmap(-1, 2**29 + 2**20, prot=mmap.PROT_READ) | |||
| large_data = large_mmap(length=2**29 + 2**20) | |||
There was a problem hiding this comment.
Regardless of the coverage bit, a PR that simply moved to a single utility function for these would be good.
|
Should be good, finally :) |
alex
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #11560. Even though the lib doesn't exist on Windows
Just realized coverage does not pass as such; the simplest solution would probably be
# type: ignore😞