refactor(admissions): do not unpack tuples in hash calculation for admissions extension types #11909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small improvement for the hash magic methods of the types added for the
Admissions
extension in #11875. I didn't pay enough attention when doing the initial implementation and overlooked an example of thepolicy_qualifiers
field inPolicyInformation
type:cryptography/src/cryptography/x509/extensions.py
Lines 893 to 901 in 916fd46
I amended the methods
ProfessionInfo.__hash__()
,Admission.__hash__()
andAdmissions.__hash__()
to avoid tuple unpacking and adjusted the none check forprofession_oids
to have the same logic as the one for thepolicy_qualifiers
. I also removed the type hint from thepq
local variable sincemypy
can infer the types starting with v1.11 (IIRC).