Revert "cryptography-cffi: substitute include path from target sysroot in cross builds (#9105)" #9131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in cross builds (pyca#9105)" The original code was right all along: it uses the official API for obtaining header locations, and it is on the build environment to ensure python supplies that in cross-build scenarios (another option is to apply a custom patch, however any such patch is not eligible for upstream submission due to its specificity). Further info: pyca#9129
alex
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code was right all along: it uses the official API for obtaining header locations, and it is on the build environment to ensure python supplies that in cross-build scenarios (another option is to apply a custom patch, however any such patch is not eligible for upstream submission due to its specificity).
Further info: #9129