change empty CRL get_revoked to empty tuple #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh, how did we miss reviewing this for so long. I'm concerned about changing this because while it obviously makes more sense, this has been like this for 7 years now so presumably there are people out there depending on the |
|
@thecubic after an almost comically long period of time I think we can merge this is if you can add a changelog entry noting this and linking to this PR (in backwards incompatible changes please). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves remaining issue in #258 by switching empty
get_revokedreturn to effective empty tuple.This was breaking functional tests in a pyOpenSSL integration.