Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change empty CRL get_revoked to empty tuple #859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/OpenSSL/crypto.py
Original file line number Diff line number Diff line change
Expand Up @@ -2137,8 +2137,7 @@ def get_revoked(self):
pyrev = Revoked.__new__(Revoked)
pyrev._revoked = _ffi.gc(revoked_copy, _lib.X509_REVOKED_free)
results.append(pyrev)
if results:
return tuple(results)
return tuple(results)

def add_revoked(self, revoked):
"""
Expand Down
2 changes: 1 addition & 1 deletion tests/test_crypto.py
Original file line number Diff line number Diff line change
Expand Up @@ -3117,7 +3117,7 @@ def test_construction(self):
"""
crl = CRL()
assert isinstance(crl, CRL)
assert crl.get_revoked() is None
assert crl.get_revoked() is ()

def _get_crl(self):
"""
Expand Down