feat: fixed should_reload behaviour, close PostgreSQL connections, block until PostgresqlWatcher is ready, refactorings
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before creating new ones
- Make PostgresqlWatcher.create_subscription_process a private method
- Rename casbin_subscription to _casbin_channel_subscription
…t and its default value
decrease select timeout to one second in child Process
remove infinite timout in PostgresqlWatcher.should_reload
create a new watcher instance for every test case
Moved channel subscription function to separate file and added context
manager for the connection, that handles SIGINT, SIGTERM for proper resource
cleanup
Closed
…f should_reload() thanks to @pradeepranwa1
pradeepranwa1
approved these changes
Jul 15, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
## [1.1.1](v1.1.0...v1.1.1) (2024-07-16) ### Bug Fixes * fixed `should_reload` behaviour, close PostgreSQL connections, block until `PostgresqlWatcher` is ready, refactorings ([#29](#29)) ([8382db4](8382db4))
|
🎉 This issue has been resolved in version 1.1.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresqlWatcher.update_callbackgets called byshould_reloadProcessgets terminatedPostgresqlWatcheris ready to receive updatesPostgresqlWatcher.should_reloadbeforeEnforcer.enforce