Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fixed should_reload behaviour, close PostgreSQL connections, block until PostgresqlWatcher is ready, refactorings #29

Merged
merged 33 commits into from
Jul 16, 2024
Merged

feat: fixed should_reload behaviour, close PostgreSQL connections, block until PostgresqlWatcher is ready, refactorings #29

merged 33 commits into from
Jul 16, 2024

Commits on Jul 8, 2024

  1. chore: updated dev requirements

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    3edbf37 View commit details
    Browse the repository at this point in the history

  2. chore: format code with black

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8101bcd View commit details
    Browse the repository at this point in the history

  3. chore: updated .gitignore

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    98ed568 View commit details
    Browse the repository at this point in the history

  4. fix: type hint, multiprocessing.Pipe is a Callable and not a type

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bb99917 View commit details
    Browse the repository at this point in the history

  5. fix: make Watcher.should_reload return value consistent

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    df1b804 View commit details
    Browse the repository at this point in the history

  6. fix: Handle Connection and Process objects consistenly and close them… 

    … before creating new ones
    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c6fb087 View commit details
    Browse the repository at this point in the history

  7. feat: Customize the postgres channel name

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    434a84c View commit details
    Browse the repository at this point in the history

  8. chore: Some code reorg 

           - Make PostgresqlWatcher.create_subscription_process a private method
       - Rename casbin_subscription to _casbin_channel_subscription
    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    90689ef View commit details
    Browse the repository at this point in the history

  9. docs: added doc string for PostgresqlWatcher.update

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    772a261 View commit details
    Browse the repository at this point in the history

  10. refactor: PostgresqlWatcher.set_update_callback

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f94294e View commit details
    Browse the repository at this point in the history

  11. refactor!: Rename 'start_process' flag to 'start_listening'

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    c26887c View commit details
    Browse the repository at this point in the history

  12. docs: Added doc string to PostgresqlWatcher.__init__

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    bc33cf5 View commit details
    Browse the repository at this point in the history

  13. fix: Added proper destructor for PostgresqlWatcher

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    9aba002 View commit details
    Browse the repository at this point in the history

  14. chore: fix type hints and proper handling of the channel_name argumen… 

    …t and its default value
    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    eb5c8f3 View commit details
    Browse the repository at this point in the history

  15. test: fix tests 

          decrease select timeout to one second in child Process
      remove infinite timout in PostgresqlWatcher.should_reload
      create a new watcher instance for every test case
    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    94e23d7 View commit details
    Browse the repository at this point in the history

  16. feat: Setup logging module for unit tests

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1db8e23 View commit details
    Browse the repository at this point in the history

  17. fix: typo

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f0e6479 View commit details
    Browse the repository at this point in the history

  18. feat: channel subscription with proper resource cleanup 

          Moved channel subscription function to separate file and added context
      manager for the connection, that handles SIGINT, SIGTERM for proper resource
      cleanup
    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    1640e75 View commit details
    Browse the repository at this point in the history

  19. chore: removed unnecessary tests

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b86a400 View commit details
    Browse the repository at this point in the history

  20. feat: Wait for Process to be ready to receive messages from PostgreSQL

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e0a6337 View commit details
    Browse the repository at this point in the history

  21. test: multiple instances of the watcher

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    87056d6 View commit details
    Browse the repository at this point in the history

  22. test: make sure every test case uses its own channel

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    af31dff View commit details
    Browse the repository at this point in the history

  23. test: no update

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    f31ba26 View commit details
    Browse the repository at this point in the history

  24. refactor: moved code into with block

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b464dcb View commit details
    Browse the repository at this point in the history

  25. feat: automaticall call the update handler if it is provided

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b130463 View commit details
    Browse the repository at this point in the history

  26. refactor: sorted imports

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    5ffe939 View commit details
    Browse the repository at this point in the history

  27. docs: updated README

    @trbtm
    trbtm committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e6a7bdc View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. refactor: improved readibility

    @trbtm
    trbtm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    09b2e8d View commit details
    Browse the repository at this point in the history

  2. refactor: resolve a potential infinite loop with a custom Exception

    @trbtm
    trbtm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    6f3c031 View commit details
    Browse the repository at this point in the history

  3. refactor: make timeout configurable by the user

    @trbtm
    trbtm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    241ac5c View commit details
    Browse the repository at this point in the history

  4. fix: docs

    @trbtm
    trbtm committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    c053715 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. fix: ensure type hint compatibility with Python 3.9

    @trbtm
    trbtm committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    63a78c3 View commit details
    Browse the repository at this point in the history

  2. feat: make sure multiple calls of update() get resolved by one call o… 

    …f should_reload() thanks to @pradeepranwa1
    @trbtm
    trbtm committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8939531 View commit details
    Browse the repository at this point in the history