Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project description in pyproject.toml (and on PyPI) is from ansible-lint rather than ansi2html #222

Closed
mtelka opened this issue Sep 8, 2023 · 6 comments
Labels
bug This issue/PR relates to a bug. packaging Packaging category

Comments

@mtelka
Copy link

mtelka commented Sep 8, 2023

The ansi2html project page at PyPI is missing project description. There is just No project description provided line there. Please add some reasonable project description for the project. Thank you.

@hartwork
Copy link
Collaborator

hartwork commented Sep 8, 2023

There is "Convert text with ANSI color codes to HTML or to LaTeX." further down but you do have a point. Thanks for the report 👍

@hartwork
Copy link
Collaborator

hartwork commented Sep 8, 2023

PS: I'm not yet sure how to fix this, only had a quick look so far. If anyone can help out with analysis or a pull request, that would be welcome. For a green CI basing on top of #221 may be a good or a bad idea, depending on view.

@mtelka
Copy link
Author

mtelka commented Sep 8, 2023

I think the project description at PyPI is set by description in pyproject.toml. Since ansi2html already have that, the only thing that needs to be done is just to release a new version and upload it to PyPI.

@mtelka mtelka closed this as completed Sep 8, 2023
@mtelka
Copy link
Author

mtelka commented Sep 8, 2023

But, OTOH, the current description looks strangely: Checks playbooks for practices and behavior that could potentially be improved. Is it correct?

@hartwork
Copy link
Collaborator

hartwork commented Sep 9, 2023

@mtelka I found that…

I have created pull request #223 to address the issue just now.

@hartwork hartwork reopened this Sep 9, 2023
@hartwork hartwork added bug This issue/PR relates to a bug. packaging Packaging category labels Sep 9, 2023
@hartwork hartwork changed the title Project description is needed Project description in pyproject.toml (and on PyPI) is from ansible-lint rather than ansi2html Sep 9, 2023
hartwork added a commit to hartwork/ansi2html that referenced this issue Sep 9, 2023
@ssbarnea
Copy link
Member

Fixed in https://pypi.org/project/ansi2html/1.9.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. packaging Packaging category
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants