Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final release for 1.9? #226

Closed
frenzymadness opened this issue Sep 23, 2023 · 7 comments
Closed

Final release for 1.9? #226

frenzymadness opened this issue Sep 23, 2023 · 7 comments
Assignees
Labels
bug This issue/PR relates to a bug.

Comments

@frenzymadness
Copy link

Hello. Would it make sense to release the final release for 1.9? The release candidate has been available since January.

@jonasstein
Copy link

@ssbarnea, @hartwork Do you have any objections to a final release?

@hartwork
Copy link
Collaborator

hartwork commented Nov 5, 2023

@jonasstein I don't have any objections but I lack permissions to (1) push to main, (2) merge without review by a second member and (3) release to PyPI. I can do without (1) but (2) and (3) are essential. If I had that it would take:

  1. First unblocking the CI by merging Fix tox and readthedocs #221

  2. Then rebase and merge…

    …ideally in that order.

  3. Doing a release off main including Git tag, GitHub release notes and PyPI release.

@ralphbean @ssbarnea can you give me the necessary permissions to be able to move forward?

@hartwork
Copy link
Collaborator

hartwork commented Dec 9, 2023

@jonasstein I don't have any objections but I lack permissions to (1) push to main, (2) merge without review by a second member and (3) release to PyPI. I can do without (1) but (2) and (3) are essential. [..]

@ralphbean @ssbarnea can you give me the necessary permissions (see above) — to be able to move forward?

CC @pycontribs

@ssbarnea
Copy link
Member

@hartwork You have green light and I hope you will make decisions. Publishing should work now with current pipeline as we no longer need secrets - i just configured the trusted publisher.

@ssbarnea ssbarnea self-assigned this Dec 11, 2023
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Dec 11, 2023
@ssbarnea
Copy link
Member

ssbarnea commented Dec 11, 2023

Released as https://pypi.org/project/ansi2html/1.9.1/

@hartwork
Copy link
Collaborator

hartwork commented Dec 11, 2023

@ssbarnea did you really just release 1.9.1 without a rendered man page while I was very clear since the beginning that it's a release blocker to not have the man page in the tarball?

Related: https://github.com/pycontribs/ansi2html/pull/202/files#r1422642651

@hartwork
Copy link
Collaborator

hartwork commented Dec 11, 2023

@hartwork You have green light and I hope you will make decisions. Publishing should work now with current pipeline as we no longer need secrets - i just configured the trusted publisher.

@ssbarnea I still cannot merge anything without approval, so I gained zero permissions and my hands are as tied as before. For the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

No branches or pull requests

4 participants