Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live page docs update #632

Merged
merged 13 commits into from
Dec 18, 2024
Merged

Live page docs update #632

merged 13 commits into from
Dec 18, 2024

Conversation

ChristopherGS
Copy link
Contributor

@ChristopherGS ChristopherGS commented Nov 28, 2024

Please merge after the new SQL editor is turned on by default @petyosi

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Ss]crollable

Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2024

Deploying logfire-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1903a0d
Status: ✅  Deploy successful!
Preview URL: https://3a933b00.logfire-docs.pages.dev
Branch Preview URL: https://cs-docs-sql-builder.logfire-docs.pages.dev

View logs

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (539311e) to head (1903a0d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #632   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          137       137           
  Lines        10929     10929           
  Branches      1524      1524           
=========================================
  Hits         10929     10929           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


6. **Organization selection panel:** Opens a drawer with links to the different organizations you are a member of, and also has links to the Terms and Conditions, Support, Documentation, and a Log Out button.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've deliberately culled a lot of these - some are no longer relevant, but the section is currently just a bit too much of a "wall of text". I've tried to pull out the key/least intuitive areas to describe

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Ss]crollable

@ChristopherGS ChristopherGS marked this pull request as ready for review December 17, 2024 12:11
@ChristopherGS ChristopherGS changed the title wip live page update Live page update Dec 17, 2024
@ChristopherGS ChristopherGS changed the title Live page update Live page docs update Dec 17, 2024
Copy link
Contributor

@summerscope summerscope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChristopherGS I'm going to finish my review and instead just go ahead and commit my changes to your PR to speed this up 👍

docs/guides/web-ui/live.md Outdated Show resolved Hide resolved
docs/guides/web-ui/live.md Outdated Show resolved Hide resolved
docs/guides/web-ui/live.md Outdated Show resolved Hide resolved
docs/guides/web-ui/live.md Outdated Show resolved Hide resolved
docs/guides/web-ui/live.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:

  • [Dd]evs

Copy link
Contributor

@summerscope summerscope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @ChristopherGS please ignore my ugly commit history - made some edits to this copy to reflect latest changes, I think we will probably want to improve this more at some point but let's not let perfect be the enemy of better. FYI we should hold off on merging this PR until we make the new SQL editor the default mode - @petyosi could you merge this bad boy once that has happened?

@summerscope summerscope changed the title Live page docs update [Don't merge yet] Live page docs update Dec 17, 2024
@summerscope summerscope changed the title [Don't merge yet] Live page docs update Live page docs update Dec 18, 2024
@summerscope summerscope merged commit 736d6da into main Dec 18, 2024
16 checks passed
@summerscope summerscope deleted the cs/docs-sql-builder branch December 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants