Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's not very ergonomic to create a span link.
Let's assume we have 2 services:
Main Service
And...
Service A
As you see, in the code, we set the headers with
logfire.propagate.get_context()
, and then on the subscriber, we need to run:We can for sure improve this. Either by passing
SpanContext
to_links
, or aLink
.This PR proposes creating:
logfire.propagate.build_span_link
: Creates a span link from aContextCarrier
, so it makes easier to use the propagate API we created. But... We can also build aspan_context
, instead ofLink
itself. It may be a bit more useful. I'm open to rework this.Link
andSpanContext
to the_links
parameter.I need to add tests here. I've first implemented this to bring back the discussion.