Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes #100

Merged
merged 3 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 53 additions & 52 deletions .github/workflows/release-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,20 +114,20 @@ jobs:
python: 313
platform_id: manylinux_aarch64

# MacOS 12 x86_64
- os: macos-12
# MacOS 13 x86_64
- os: macos-13
python: 39
platform_id: macosx_x86_64
- os: macos-12
- os: macos-13
python: 310
platform_id: macosx_x86_64
- os: macos-12
- os: macos-13
python: 311
platform_id: macosx_x86_64
- os: macos-12
- os: macos-13
python: 312
platform_id: macosx_x86_64
- os: macos-12
- os: macos-13
python: 313
platform_id: macosx_x86_64

Expand Down Expand Up @@ -222,58 +222,59 @@ jobs:
name: wheel-${{ matrix.python }}-${{ matrix.platform_id }}
path: ./dist/*.whl

test-package:
name: Test built package
needs: [ build-wheels, build-sdist, build-wheels-macos-arm64 ]
runs-on: ubuntu-latest
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']

steps:
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}

- name: Download the wheels
uses: actions/download-artifact@v4
with:
path: dist/
merge-multiple: true

- name: Install from package wheels and test
run: |
python -m venv testwhl
source testwhl/bin/activate
python -m pip install -U pip
python -m pip install pytest pydicom pylibjpeg
python -m pip uninstall -y pylibjpeg-openjpeg
python -m pip install git+https://github.com/pydicom/pylibjpeg-data
python -m pip install -U --pre --find-links dist/ pylibjpeg-openjpeg
python -m pytest --pyargs openjpeg.tests
deactivate

- name: Install from package tarball and test
run: |
python -m venv testsrc
source testsrc/bin/activate
python -m pip install -U pip
python -m pip install pytest pydicom pylibjpeg
python -m pip uninstall -y pylibjpeg-openjpeg
python -m pip install git+https://github.com/pydicom/pylibjpeg-data
python -m pip install -U dist/pylibjpeg*openjpeg-*.tar.gz
python -m pytest --pyargs openjpeg.tests
deactivate
# test-package:
# name: Test built package
# needs: [ build-wheels, build-sdist, build-wheels-macos-arm64 ]
# runs-on: ubuntu-latest
# timeout-minutes: 30
# strategy:
# fail-fast: false
# matrix:
# python-version: ['3.9', '3.10', '3.11', '3.12', '3.13']
#
# steps:
# - name: Set up Python ${{ matrix.python-version }}
# uses: actions/setup-python@v5
# with:
# python-version: ${{ matrix.python-version }}
#
# - name: Download the wheels
# uses: actions/download-artifact@v4
# with:
# path: dist/
# merge-multiple: true
#
# - name: Install from package wheels and test
# run: |
# python -m venv testwhl
# source testwhl/bin/activate
# python -m pip install -U pip
# python -m pip install pytest pydicom pylibjpeg
# python -m pip uninstall -y pylibjpeg-openjpeg
# python -m pip install git+https://github.com/pydicom/pylibjpeg-data
# python -m pip install -U --pre --find-links dist/ pylibjpeg-openjpeg
# python -m pytest --pyargs openjpeg.tests
# deactivate
#
# - name: Install from package tarball and test
# run: |
# python -m venv testsrc
# source testsrc/bin/activate
# python -m pip install -U pip
# python -m pip install pytest pydicom pylibjpeg
# python -m pip uninstall -y pylibjpeg-openjpeg
# python -m pip install git+https://github.com/pydicom/pylibjpeg-data
# python -m pip install -U dist/pylibjpeg*openjpeg-*.tar.gz
# python -m pytest --pyargs openjpeg.tests
# deactivate

# The pypi upload fails with non-linux containers, so grab the uploaded
# artifacts and run using those
# See: https://github.com/pypa/gh-action-pypi-publish/discussions/15
deploy:
name: Upload wheels to PyPI
needs: [ test-package ]
# needs: [ test-package ]
needs: [ build-wheels, build-sdist, build-wheels-macos-arm64 ]
runs-on: ubuntu-latest
environment:
name: pypi
Expand Down
8 changes: 0 additions & 8 deletions docs/changes/v2.4.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,3 @@ Changes
* Supported Python versions are 3.9 to 3.13.
* NumPy < 2.0 is no longer supported.
* Switched to OpenJpeg v2.5.2

Known Issues
------------

* OpenJpeg seems to be unable to correctly encode image data with more than 16-bit
precision when running on big endian systems
* Encoding images on little endian systems works with up to 24-bit precision, but the
results for lossy encoding can be extremely poor for more than 20+ bits.
Loading