Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in registry entries created when python is installed with --register #660

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

DavidCEllis
Copy link

Fixes for #656

Fix typo in the registry entry names:

  • 'DiplayName' is corrected to 'DisplayName' (missing 's')

Correctly identifies 32-bit Python installed on a 64-bit machine:

  • 'DisplayName' will now show '(32-bit)' instead of '(64-bit)' for 32 bit installs
  • 'SysArchitecture' will now show '32bit' instead of '64bit' for 32 bit installs
  • 'Version' no longer includes '-win32' for 32 bit installs
  • 'Company' and 'Tag' are unchanged
    • eg a 32 bit Python 3.12.5 install will still be under PythonCore\3.12.5-win32 as it was before.

These changes match the values you get if you install 32 bit python for the current user through the python.org installers (apart from pyenv-win using the 3 part version number and -win32 instead of -32 in the 'Tag').

@DavidCEllis DavidCEllis requested a review from a team as a code owner August 28, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants