Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated (and broke some) tools, add some docs. #389

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

updated (and broke some) tools, add some docs. #389

wants to merge 24 commits into from

Conversation

arsenovic
Copy link
Member

updated some frame2mat, mat2frame methods to take a psuedo-scalar for frame instead of a layout, which is unneccsary and restrictive.
also updated some docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2020

This pull request fixes 1 alert when merging 7d9569c into ddbf8d7 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@arsenovic @eric-wieser
Update docs/tutorials/g3-algebra-of-space.ipynb
97bbf64 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
eric-wieser reviewed Dec 29, 2020
View reviewed changes
clifford/__init__.py Outdated Show resolved Hide resolved
clifford/__init__.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Dec 29, 2020

This pull request fixes 1 alert when merging 97bbf64 into ddbf8d7 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

arsenovic and others added 2 commits December 30, 2020 07:37
@arsenovic @eric-wieser
Update clifford/__init__.py
434dbd2 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@arsenovic @eric-wieser
Update clifford/__init__.py
e90b594 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@lgtm-com
Copy link

lgtm-com bot commented Dec 30, 2020

This pull request fixes 1 alert when merging e90b594 into ddbf8d7 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Dec 31, 2020

This pull request fixes 1 alert when merging f9ff2dc into ddbf8d7 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Dec 31, 2020

This pull request fixes 1 alert when merging 6bd529c into ddbf8d7 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@eric-wieser
Copy link
Member

The docs for frame2Mat look wrong; perhaps some missing :s in the docstring?

arsenovic and others added 2 commits January 4, 2021 08:11
@arsenovic @eric-wieser
Update clifford/tools/__init__.py
d283fa5 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@arsenovic
docfixs
5d81208
@lgtm-com
Copy link

lgtm-com bot commented Jan 4, 2021

This pull request fixes 1 alert when merging 5d81208 into ddbf8d7 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Feb 4, 2021

This pull request fixes 1 alert when merging fc44e78 into 1b56672 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Feb 4, 2021

This pull request fixes 1 alert when merging 2595f28 into 1b56672 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request fixes 1 alert when merging b36a713 into 1b56672 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Feb 5, 2021

This pull request fixes 1 alert when merging 045b006 into 1b56672 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Feb 7, 2021

This pull request fixes 1 alert when merging dbe768c into 1b56672 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

@eric-wieser eric-wieser mentioned this pull request Jul 19, 2021
Merged
eric-wieser added a commit that referenced this pull request Jul 19, 2021
@eric-wieser
Update the release notes (#403)
659f75b 
This change:

* Adds documentation for the numba extension support
* Adds a summary of all the changes to multivector inverses
* Adds changelog entries for 1.4.0
* Pulls in two doc changes from #389
* Fixes weird indentation in the changelog page
* Updates the sphinx theme for good measure
@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2021

This pull request fixes 1 alert when merging bfbd85e into 659f75b - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arsenovic @eric-wieser