Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from setuptools to meson-python #345

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

lazka
Copy link
Member

@lazka lazka commented Oct 21, 2023

This is currently blocked on meson-python not supporting cross compiling for arm64 on Windows.

Cross compiling is currently a hack between setuptools and cibuildwheel and not part of any spec, so it's not clear where this should be fixed.

We could drop arm64 wheels to unblock this.

@lazka lazka force-pushed the meson-py branch 2 times, most recently from cea6e89 to 40476af Compare October 22, 2023 08:22
@lazka lazka changed the title meson-python Port from setuptools to meson-python Oct 22, 2023
@stuaxo
Copy link
Collaborator

stuaxo commented Jan 19, 2024

Is there an upstream bug for meson-python not supporting arm64 ?

@lazka
Copy link
Member Author

lazka commented Jan 19, 2024

It's not about arm64, it's about cross compiling. And from what I remember the Python build backend APIs don't provide interfaces for cross compiling, so there is no standard way to implement it in a build backend, and in setuptools it works because of hacks.

mesonbuild/meson-python#321 seems relevant.

@lazka
Copy link
Member Author

lazka commented Jan 19, 2024

I wouldn't mind dropping arm64 again... but I also don't mind just keeping this open until something changes.

@amolenaar
Copy link

Do you have any download stats for the win/arm64 wheel?

@lazka
Copy link
Member Author

lazka commented Jun 18, 2024

Do you have any download stats for the win/arm64 wheel?

I don't know how I would get that.

@lazka
Copy link
Member Author

lazka commented Jun 28, 2024

There are rumors that we'll get arm64 windows CI this year, so I think it's fine to continue with this, since there is a fix in sight.

@lazka
Copy link
Member Author

lazka commented Jun 28, 2024

Got some numbers now using pypinfo: In the last 90 days, there were 49047 Windows wheel downloads, 24 (0.05%) of those for arm64, 598 (1.22%) of those for win32, 48449 (98.83%) for win_amd64.

arm64 is dropped since cross compiling isn't supported except with setuptools.
We'll have to wait for native GHA runners
@lazka lazka marked this pull request as ready for review July 25, 2024 14:33
@lazka lazka merged commit 339dc62 into pygobject:main Aug 29, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants