Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml and common workflows #17

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Conversation

fsoubelet
Copy link
Member

@fsoubelet fsoubelet commented Aug 12, 2024

Next in the wave of PRs transitioning our packages to using the standard pyproject.toml file.

Important

The setup.py file is gone. A pyproject.toml file now centralises everything, including metadata conformly to PEP621.

I have put down hatchling as a build backend, as it is the one developped by PyPA, the Python Packaging Authority, as they publish the authoritative user guide. This has little impact though, as any PEP518-compliant backend would work there instead.

Like for all other packages, this moves the minimum supported Python version to 3.9.

Details

I have put Hatch as a packaging tool as it is also the one from PyPA, but it is strictly optional. One does not need Hatch, because standards. The new common workflows (PR upcoming) don't even use it.

I have taken upon me to up some minimum required versions (numpy for instance), for uniformity with the rest of the packages.

Additional

This PR also moves generic_parser to the common Github Actions workflows, and brings very minor lints.

@fsoubelet fsoubelet added Type: Documentation Improvements, updates and fixes to the documentation. Type: Feature A (suggetion for a) new feature or enhancement in functionality. Type: CI/CD Improvements, updates and fixes to the continuous integration. labels Aug 12, 2024
@fsoubelet fsoubelet requested a review from JoschD August 12, 2024 12:01
@fsoubelet fsoubelet self-assigned this Aug 12, 2024
@fsoubelet
Copy link
Member Author

As with other PRs where migration to common workflows was done, I will update the requested passing tests when the PR is accepted.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@fsoubelet fsoubelet requested a review from JoschD August 13, 2024 12:14
@fsoubelet fsoubelet merged commit c5aca3c into master Aug 13, 2024
18 checks passed
@fsoubelet fsoubelet deleted the pyproject branch August 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI/CD Improvements, updates and fixes to the continuous integration. Type: Documentation Improvements, updates and fixes to the documentation. Type: Feature A (suggetion for a) new feature or enhancement in functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants