Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOROS: oscillations and positions #20

Merged
merged 3 commits into from
Oct 11, 2024
Merged

DOROS: oscillations and positions #20

merged 3 commits into from
Oct 11, 2024

Conversation

JoschD
Copy link
Member

@JoschD JoschD commented Oct 9, 2024

Enables the capability to read also the oscillation data from DOROS and the means to switch between positions and oscillations data.

@JoschD JoschD added Type: Feature A (suggetion for a) new feature or enhancement in functionality. Domain: GUI Closely related to GUI and/or needs GUI changes as well. Type: Release Issue preparing for a release. Status: Review Needed Work currently stopped, untils someone else reviews it. Priority: Medium Work on this. Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. labels Oct 9, 2024
@JoschD JoschD self-assigned this Oct 9, 2024
fsoubelet
fsoubelet approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@fsoubelet fsoubelet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOROS stuff is getting a bit convoluted but this is transparent to the user so I'm fine with it

turn_by_turn/io.py Show resolved Hide resolved
turn_by_turn/io.py Outdated Show resolved Hide resolved
@JoschD JoschD merged commit 3163c5e into master Oct 11, 2024
18 checks passed
@JoschD JoschD deleted the doros_oscillations_positions branch October 11, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsoubelet fsoubelet fsoubelet approved these changes

@jgray-19 jgray-19 jgray-19 approved these changes

Assignees

@JoschD JoschD

Labels
Domain: GUI Closely related to GUI and/or needs GUI changes as well. Estimate: Normal Straightforward, but might require some time. Probably needs additional tests. Priority: Medium Work on this. Status: Review Needed Work currently stopped, untils someone else reviews it. Type: Feature A (suggetion for a) new feature or enhancement in functionality. Type: Release Issue preparing for a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoschD @fsoubelet @jgray-19