-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote most dunder definitions on FunctionModel
to ObjectModel
#1519
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 2447909857
π - Coveralls |
DunderCompletionMixin
to allow further dunder methods on ModuleModel
ModuleModel
to ObjectModel
ModuleModel
to ObjectModel
Removing this from |
9987ee5
to
4b7dae7
Compare
Okay, I applied your diff. Merging I'll need to investigate that. |
Hm, it seems that moving these things to |
π€ |
b9b0708
to
8888eba
Compare
This is getting closer to completion. The only issue is now that whenever we overwrite I tried to dig a little deeper but I would like to merge the other PRs first before tackling this one again. |
8888eba
to
995e3ff
Compare
995e3ff
to
a235a71
Compare
FunctionModel
to ObjectModel
Closing as I don't have immediate plans to work on this. |
@jacobtylerwalls Could you restore the branch? I actually wanted to complete this π |
In the spirit of fixing stale PR's: |
Thanks for the suggestion. I think with the time on hand, my priorities for the moment are triage, performance, and #2048. So I'm unlikely to return to this. |
Description
Create
DunderCompletionMixin
in order to letModuleModel
share the same dunder definitions that were already present onFunctionModel
.Type of Changes
Related Issue
Refs pylint-dev/pylint#6094