-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __init__
to the ObjectModel
and return BoundMethods
#1687
Conversation
Pull Request Test Coverage Report for Build 2622711369
π - Coveralls |
__init__
to the ObjectModel
__init__
to the ObjectModel
and return BoundMethods
After testing on I think now I (finally) fixed those. I was mistaken to think that the other We will infer the result of these |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
This feels like a new feature to some degree. What do you think about a short changelog? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
Steps
Description
Type of Changes
Related Issue
Blocked by #1686
Precedes #1519
@jacobtylerwalls Please only consider the last commit. This is the next step in "completing" our
ObjectModel
. Since all objects have an__init__
that normally returnsNone
we can defineattr___init__
onObjectModel
.