Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release tests #2491

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Fix release tests #2491

merged 1 commit into from
Aug 4, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Aug 4, 2024 •
edited
Loading

DanielNoord
DanielNoord approved these changes Aug 4, 2024
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you understand why were are experiencing this while we don't use Python 3.5? Changes make sense to me and the successful run is good, but it seems weird we need this for a version that is not yet EOL?

@jacobtylerwalls
Copy link
Member Author

I wondered that also. I don't know for a fact, but it might have something to do with this behavior change before Python 3.10.

@jacobtylerwalls jacobtylerwalls merged commit f37549e into main Aug 4, 2024
14 of 15 checks passed
@jacobtylerwalls jacobtylerwalls deleted the jtw/fix-release-tests branch August 4, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @DanielNoord