Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated head_of_apache pre-commit step #7647

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

lucianopaz
Copy link
Contributor

@lucianopaz lucianopaz commented Jan 15, 2025

This PR re-enables the pre commit step that applies the Apache v2 license header to all files. The updated version now always renders a year range, and the end year is set to the current year (as long as it has not been manually set to present)


📚 Documentation preview 📚: https://pymc--7647.org.readthedocs.build/en/7647/

@lucianopaz lucianopaz added maintenance no releasenotes Skipped in automatic release notes generation labels Jan 15, 2025
@ricardoV94
Copy link
Member

ricardoV94 commented Jan 16, 2025

I thought the ideal was start-present, like 2022-present? CC @OriolAbril

@lucianopaz
Copy link
Contributor Author

I thought the ideal was start-present, like 2022-present? CC @OriolAbril

I set it to the actual year on purpose. The hook will update the end year to the current year automatically. If you prefer, I can add an argument to use the start - present format instead.

@ricardoV94
Copy link
Member

It also has the advantage we don't need a commit on every file every year

@lucianopaz lucianopaz force-pushed the reenable_head_of_apache branch from d838fe6 to 9260d6b Compare January 19, 2025 21:53
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (671d704) to head (9260d6b).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7647      +/-   ##
==========================================
+ Coverage   87.41%   92.77%   +5.36%     
==========================================
  Files         107      107              
  Lines       18168    18178      +10     
==========================================
+ Hits        15881    16865     +984     
+ Misses       2287     1313     -974     
Files with missing lines Coverage Δ
pymc/__init__.py 100.00% <ø> (ø)
pymc/backends/__init__.py 92.68% <ø> (ø)
pymc/backends/arviz.py 95.76% <ø> (ø)
pymc/backends/base.py 88.69% <ø> (ø)
pymc/backends/mcbackend.py 99.25% <ø> (ø)
pymc/backends/ndarray.py 80.00% <ø> (ø)
pymc/backends/report.py 78.84% <ø> (ø)
pymc/backends/zarr.py 93.81% <ø> (-1.86%) ⬇️
pymc/blocking.py 97.67% <ø> (ø)
pymc/data.py 89.22% <ø> (ø)
... and 97 more

@ricardoV94 ricardoV94 merged commit aad5400 into pymc-devs:main Jan 20, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance no releasenotes Skipped in automatic release notes generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants