Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyodide lockfile add-wheels does not append files #28

Open
Konkrad opened this issue Jun 6, 2024 · 0 comments · May be fixed by #29
Open

pyodide lockfile add-wheels does not append files #28

Konkrad opened this issue Jun 6, 2024 · 0 comments · May be fixed by #29

Comments

@Konkrad
Copy link

Konkrad commented Jun 6, 2024

Hello,
I tried today to use this command to add new wheels to an existing pyodide-lock.json

pyodide lockfile add-wheels

Unfortunately it did not append any dependencies to an existing file. After some digging I figured out that the error is in this file:

https://github.com/pyodide/pyodide-lock/blob/main/pyodide_lock/cli.py#L50

The following code fixes it:

sp = PyodideLockSpec.from_json(input)
sp = add_wheels_to_spec(
        sp,
        wheels,
        base_path=base_path,
        base_url=wheel_url,
        ignore_missing_dependencies=ignore_missing_dependencies,
    )
    sp.to_json(output)
@Konkrad Konkrad linked a pull request Jun 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add wheel command to not generate output Konkrad/pyodide-lock
1 participant
@Konkrad