-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTR] StochastiOCP merge #715
Conversation
@pariterre think we could merge? |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
- Coverage 81.75% 81.44% -0.31%
==========================================
Files 124 129 +5
Lines 14059 15466 +1407
==========================================
+ Hits 11494 12597 +1103
- Misses 2565 2869 +304
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only two minors comment and we are good to go!
Reviewed 33 of 33 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @EveCharbie)
OCP_equation.png
line 0 at r3 (raw file):
Is this useful/mandatory? If so, could it be replaced by a <100kB file?
bioptim/examples/stochastic_optimal_control/arm_reaching_muscle_driven.py
line 53 at r3 (raw file):
nlp: NonLinearProgram, motor_noise, sensory_noise,
I love those names!
bioptim/examples/stochastic_optimal_control/LeuvenArmModel.py
line 5 at r3 (raw file):
""" from typing import Callable
Quick change can you name the file as snake_case_file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @pariterre)
OCP_equation.png
line at r3 (raw file):
Previously, pariterre (Pariterre) wrote…
Is this useful/mandatory? If so, could it be replaced by a <100kB file?
OK
bioptim/examples/stochastic_optimal_control/arm_reaching_muscle_driven.py
line 53 at r3 (raw file):
Previously, pariterre (Pariterre) wrote…
I love those names!
Done.
bioptim/examples/stochastic_optimal_control/LeuvenArmModel.py
line 5 at r3 (raw file):
Previously, pariterre (Pariterre) wrote…
Quick change can you name the file as snake_case_file?
Done.
@pariterre Should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)
to have no more surprises pyomeca#706
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is