-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RTM] added multi-node penalties to objective plots #726
[RTM] added multi-node penalties to objective plots #726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)
bioptim/examples/getting_started/example_multinode_objective.py
line 120 at r1 (raw file):
n_shooting = 30 ocp = prepare_ocp(biorbd_model_path="models/pendulum.bioMod", final_time=1, n_shooting=n_shooting) # ocp.add_plot_penalty(CostType.ALL)
Can be uncomment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pariterre)
bioptim/examples/getting_started/example_multinode_objective.py
line 120 at r1 (raw file):
Previously, pariterre (Pariterre) wrote…
Can be uncomment
Done.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
- Coverage 81.77% 81.67% -0.10%
==========================================
Files 130 130
Lines 15804 15846 +42
==========================================
+ Hits 12923 12942 +19
- Misses 2881 2904 +23
☔ View full report in Codecov by Sentry. |
@pariterre I think we are good to go :) |
All Submissions:
New Feature Submissions:
black . -l120 --exclude "external/*"
)?Changes to Core Features:
This change is