Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTM] added multi-node penalties to objective plots #726

Merged
merged 11 commits into from
Jul 21, 2023

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Jul 19, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request? Issue add multinode penalties to add_plot_penalty #725
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

pariterre
pariterre previously approved these changes Jul 19, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


bioptim/examples/getting_started/example_multinode_objective.py line 120 at r1 (raw file):

    n_shooting = 30
    ocp = prepare_ocp(biorbd_model_path="models/pendulum.bioMod", final_time=1, n_shooting=n_shooting)
    # ocp.add_plot_penalty(CostType.ALL)

Can be uncomment

@pariterre pariterre changed the title [RTR] added multi-node penalties to objective plots [RTM] added multi-node penalties to objective plots Jul 19, 2023
Copy link
Collaborator Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pariterre)


bioptim/examples/getting_started/example_multinode_objective.py line 120 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Can be uncomment

Done.

@EveCharbie EveCharbie changed the title [RTM] added multi-node penalties to objective plots [WIP] added multi-node penalties to objective plots Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage: 39.58% and project coverage change: -0.10 ⚠️

Comparison is base (04720af) 81.77% compared to head (0fc3e0c) 81.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   81.77%   81.67%   -0.10%     
==========================================
  Files         130      130              
  Lines       15804    15846      +42     
==========================================
+ Hits        12923    12942      +19     
- Misses       2881     2904      +23     
Impacted Files Coverage Δ
...les/getting_started/example_multinode_objective.py 82.35% <0.00%> (-2.50%) ⬇️
bioptim/optimization/optimal_control_program.py 86.20% <28.57%> (-1.01%) ⬇️
bioptim/gui/plot.py 70.65% <46.87%> (-0.89%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EveCharbie EveCharbie changed the title [WIP] added multi-node penalties to objective plots [RTM if tests pass] added multi-node penalties to objective plots Jul 21, 2023
@EveCharbie EveCharbie changed the title [RTM if tests pass] added multi-node penalties to objective plots [RTM] added multi-node penalties to objective plots Jul 21, 2023
@EveCharbie
Copy link
Collaborator Author

@pariterre I think we are good to go :)

@pariterre pariterre merged commit b41eaa9 into pyomeca:master Jul 21, 2023
4 of 6 checks passed
@EveCharbie EveCharbie deleted the multinode_penlaties_on_graphs branch September 1, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants