Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time dependent tests #886

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Time dependent tests #886

merged 7 commits into from
Jul 25, 2024

Conversation

Kev1CO
Copy link
Collaborator

@Kev1CO Kev1CO commented Jul 22, 2024

All Submissions:

  • Have you followed the guidelines in our Contributing document [docs/contribution.md]?
  • Have you checked to ensure there aren't other open [Pull Requests] for the same update/change?
  • Have you opened/linked the issue related to your pull request?
  • Have you used the tag [WIP] for on-going changes, and removed it when the pull request was ready?
  • When ready to merge, have you sent a comment pinging @pariterre in it?

New Feature Submissions:

  1. Does your submission pass the tests (if not please explain why this is intended)?
  2. Did you write a proper documentation (docstrings and ReadMe)
  3. Have you linted your code locally prior to submission (using the command: black . -l120 --exclude "external/*")?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new examples for your core changes, as applicable?
  • Have you written new tests for your core changes, as applicable?

This change is Reviewable

@Kev1CO Kev1CO changed the title Time dependent tests [WIP] Time dependent tests Jul 22, 2024
@Kev1CO Kev1CO changed the title [WIP] Time dependent tests [RTR] Time dependent tests Jul 22, 2024
pariterre
pariterre previously approved these changes Jul 25, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Kev1CO)

@pariterre pariterre changed the title [RTR] Time dependent tests [RTM when tests pass] Time dependent tests Jul 25, 2024
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Kev1CO)

@pariterre pariterre changed the title [RTM when tests pass] Time dependent tests Time dependent tests Jul 25, 2024
@pariterre pariterre merged commit 53af492 into pyomeca:master Jul 25, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants